Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate wazuh.yml configuration to opensearch_dashboards.yml #7175

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Migrate wazuh.yml configuration to opensearch_dashboards.yml #7175

wants to merge 25 commits into from
+1,062 −3,078

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Nov 25, 2024 •
edited
Loading

Description

This PR move the location of the wazuh.yml to opensearch_dashboards.yml

Closes wazuh/wazuh-dashboard#339

Test

Check the Dashboard Management > Advanced settings validations

Field Type Validations Chrome Firefox Safari 
alerts.sample.prefix EpluginSettingType.text - String
- notEmpty
- noSpaces
- noStartsWith('-', '_', '+', '.')
- noInvalidCharacters('\', '/', '?', '"', '<', '>', '#', '*')		 ⚫ ⚫ ⚫
configuration.ui_api_editable EpluginSettingType.switch - Boolean ⚫ ⚫ ⚫
cron.prefix EpluginSettingType.text - String
- notEmpty
- noSpaces
- noStartsWith('-', '_', '+', '.')
- noInvalidCharacters('\', '/', '?', '"', '<', '>','#', '*')		 ⚫ ⚫ ⚫
customization.enabled EpluginSettingType.switch - Boolean ⚫ ⚫ ⚫
enrollment.dns EpluginSettingType.text - String
- serverAddressHostnameFQDNIPv4IPv6		 ⚫ ⚫ ⚫
enrollment.password EpluginSettingType.text - String ⚫ ⚫ ⚫
hideManagerAlerts EpluginSettingType.switch - Boolean ⚫ ⚫ ⚫
ip.ignore EpluginSettingType.editor - Array of:
- String
- notEmpty
- noSpaces
- noLiteralString('.', '..')
- noStartsWith('-', '_', '+', '.')
- noInvalidCharacters('\', '/', '?', '"', '<', '>', '#')		 ⚫ ⚫ ⚫
ip.selector EpluginSettingType.switch - Boolean ⚫ ⚫ ⚫
wazuh.updates.disabled EpluginSettingType.switch - Boolean ⚫ ⚫ ⚫
pattern EpluginSettingType.text - String
- notEmpty
- noSpaces
- noLiteralString('.', '..')
- noStartsWith('-', '_', '+', '.')
- noInvalidCharacters('\', '/', '?', '"', '<', '>', '#')		 ⚫ ⚫ ⚫
timeout EpluginSettingType.number - Number (min: 1500, integer) ⚫ ⚫ ⚫
vulnerabilities.pattern EpluginSettingType.text - String
- notEmpty
- noSpaces
- noLiteralString('.', '..')
- noStartsWith('-', '_', '+', '.')
- noInvalidCharacters('\', '/', '?', '"', '<', '>', ',', '#')		 ⚫ ⚫ ⚫

Check the opensearch_dashboards.yml validations

Field Type Validations Chrome Firefox Safari 
hosts EpluginSettingType.objectOf url:
- String
- notEmpty
port:
- Number (0-65535)
username:
- String
- notEmpty
password:
- String
- notEmpty
run_as:
- Boolean		 ⚫ ⚫ ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.71% ( 400 / 875 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 45.9% ( 398 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Main plugin code coverage (Jest) test % values
Statements 13.43% ( 4027 / 29984 )
Branches 8.96% ( 1749 / 19516 )
Functions 12.98% ( 944 / 7270 )
Lines 13.59% ( 3925 / 28861 )

@Machi3mfl
Add advanced settings (ui_settings)
25886e3
@Machi3mfl
Move all configurations to yml and ui settings
0467def
@Machi3mfl
Add new configuration providers and repository
c7922d3
@Machi3mfl
Update providers
c933616
@Machi3mfl
Update core with new configuration store interface
4855482
@Machi3mfl
Fix main errores
94a9dad
@Machi3mfl
Create configuration services folder on common
1dacb0b
@Machi3mfl
Update server configuration services and types
634f43d
@Machi3mfl
Create public configuration types
511b3e5
@Machi3mfl
Apply new configuration store implementation on server
d6b66e5
@Machi3mfl
Apply new configuration store implementation on public context
9a4d2fe
@Machi3mfl
Moved ui settings to common
3ab5831
@Machi3mfl
Update providers and configuration types
e5d0f95
@Machi3mfl
Use configuration service on public
4fc58e2
@Machi3mfl
Add configuration store unit tests
ff50249
@Machi3mfl
Update configuration service unit tests
86bc999
@Machi3mfl
Adapt the plugin settings to ui settings
bced596
@Machi3mfl
Use settings adapter to create plugin config
d6ae59d
@Machi3mfl
Merge branch 'master' into enhancement/migrate-wazuh-configuration
ddea925
@Machi3mfl
Fix conflicts with master
da87f62
@Machi3mfl Machi3mfl marked this pull request as ready for review December 20, 2024 19:27
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Engine plugin code coverage (Jest) test % values
Statements 8.63% ( 64 / 741 )
Branches 7.94% ( 22 / 277 )
Functions 1.87% ( 7 / 373 )
Lines 9.1% ( 64 / 703 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Fleet plugin code coverage (Jest) test % values
Statements 4.68% ( 9 / 192 )
Branches 16.66% ( 7 / 42 )
Functions 1.11% ( 1 / 90 )
Lines 4.76% ( 9 / 189 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@chantal-kelm chantal-kelm self-requested a review December 20, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm Awaiting requested review from chantal-kelm

At least 1 approving review is required to merge this pull request.

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate wazuh.yml configuration to opensearch_dashboard.yml
1 participant
@Machi3mfl